Added ability to unzip rar and 7z formats. #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bdirectories of all archive types.
|
In #566 I already added 7z through LzmaSDKObjC framework. It is missing RAR. I'd merge but there's a bunch of conflicts since I already added code paths for 7z. |
JoeMatt
added
the
enhancement
|
@tkunstek would it be possible to remove the 7z support from this PR so that it only includes RAR? Or are the two formats provided by the same lib? |
|
Library used supports both formats. You can reject this PR and I'll come back through and add 7z separately. |
|
Just to clarify it’s the RAR support that needs adding separately - 7z was added with @JoeMatt’s megaPR |
|
Ah. I can still add RAR too if it will benefit someone. |
|
If this were to be added it would make sense to remove my LzmaSDKObjC dependency and depend on SARUnArchiveANY solely to reduce dependency management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to unzip rar and 7z formats. Now also finds files in subdirectories of all archive types.